feat(storage): add resource span attributes for ACO ( App Centric Obs… - #16285
feat(storage): add resource span attributes for ACO ( App Centric Obs…#16285bajajneha27 wants to merge 2 commits into
Conversation
…ervability ) for rewrite API in async client
product-auto-label
Bot
added
the
api: storage
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for span enrichment in RewriteObject within the asynchronous connection tracing implementation. It introduces an overload of MakeTracingAsyncRewriterConnection that accepts an OpenTelemetry span, allowing the span to be created and enriched with destination bucket details before being passed to the tracing connection. A unit test has been added to verify that the span is correctly enriched using cached bucket metadata. I have no feedback to provide as the changes are well-implemented and include appropriate test coverage.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16285 +/- ##
=======================================
Coverage 92.30% 92.31%
=======================================
Files 2223 2223
Lines 208086 208121 +35
=======================================
+ Hits 192074 192117 +43
+ Misses 16012 16004 -8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
/gcbrun |
2 participants
…ervability ) for rewrite API in async client